runtime stats by application version #3362
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3362 +/- ##
=========================================
- Coverage 9.27% 9.24% -0.03%
=========================================
Files 36 36
Lines 5992 6011 +19
=========================================
Hits 556 556
- Misses 5436 5455 +19
|
|
I'm not convinced this is desirable. |
|
@davidpanderson Do you mean just the change to apps.php or the whole thing? I know SETIguy desires the runtime stats for the reasons he explained in issue #3356. |
|
The whole thing. Additions to the DB affect all projects, and there needs to be a compelling case for them. |
|
We've got two projects that want this change. I want it because the
scheduler is broken for GPU and multithreaded apps and the validator credit
is broken for multithreaded apps. It's always been broken, and this is a
small step toward fixing that. Having suffered through hundreds of database
changes no project was calling for, I understand that inconvenience.
…On Wed, Oct 30, 2019 at 3:50 PM David Anderson ***@***.***> wrote:
The whole thing. Additions to the DB affect all projects, and there needs
to be a compelling case for them.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#3362?email_source=notifications&email_token=ACS5ZMS4Q6LHY4N7EFZXPDTQRIFRRA5CNFSM4JHA2DGKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECWASQA#issuecomment-548145472>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACS5ZMVHJOOCIYDV76QNHETQRIFRRANCNFSM4JHA2DGA>
.
--
Eric Korpela
[email protected]
AST:7731^29u18e3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3356
Description of the Change
Added these 4 fields to both the app_version table and the host_app_version table:
runtime_nruntime_avgcputime_ncputime_avgModified validator to track the values. Added the necessary function to db_update to make the database change. Added average run time and cpu time columns to the apps.php page.
Release Notes
Adds fields to database to track average run times by application version. Modifies apps.php to display the average run times and cpu times.